[1/4] ARM: EXYNOS: Remove smp_init_cpus hook from platsmp.c
Alim Akhtar
alim.akhtar at samsung.com
Fri Nov 4 05:53:04 PDT 2016
Hi Pankaj,
On 11/04/2016 09:09 AM, Pankaj Dubey wrote:
> We can safely remove exynos_smp_init_cpus() hook from mach-exynos/platsmp.c,
> as all SMP platforms in mach-exynos can rely on DT for CPU core description
> instead of determining number of cores from the SCU.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey at samsung.com>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar at samsung.com>
> arch/arm/mach-exynos/platsmp.c | 31 -------------------------------
> 1 file changed, 31 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 98ffe1e..a5d6841 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -385,36 +385,6 @@ fail:
> return pen_release != -1 ? ret : 0;
> }
>
> -/*
> - * Initialise the CPU possible map early - this describes the CPUs
> - * which may be present or become present in the system.
> - */
> -
> -static void __init exynos_smp_init_cpus(void)
> -{
> - void __iomem *scu_base = scu_base_addr();
> - unsigned int i, ncores;
> -
> - if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
> - ncores = scu_base ? scu_get_core_count(scu_base) : 1;
> - else
> - /*
> - * CPU Nodes are passed thru DT and set_cpu_possible
> - * is set by "arm_dt_init_cpu_maps".
> - */
> - return;
> -
> - /* sanity check */
> - if (ncores > nr_cpu_ids) {
> - pr_warn("SMP: %u cores greater than maximum (%u), clipping\n",
> - ncores, nr_cpu_ids);
> - ncores = nr_cpu_ids;
> - }
> -
> - for (i = 0; i < ncores; i++)
> - set_cpu_possible(i, true);
> -}
> -
> static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
> {
> int i;
> @@ -479,7 +449,6 @@ static void exynos_cpu_die(unsigned int cpu)
> #endif /* CONFIG_HOTPLUG_CPU */
>
> const struct smp_operations exynos_smp_ops __initconst = {
> - .smp_init_cpus = exynos_smp_init_cpus,
> .smp_prepare_cpus = exynos_smp_prepare_cpus,
> .smp_secondary_init = exynos_secondary_init,
> .smp_boot_secondary = exynos_boot_secondary,
>
More information about the linux-arm-kernel
mailing list