mx6ul cannot reboot

Fabio Estevam festevam at gmail.com
Thu May 19 19:47:55 PDT 2016


On Thu, May 19, 2016 at 11:39 PM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Jacky,
>
> On Thu, May 19, 2016 at 11:25 PM, Ping Bai <ping.bai at nxp.com> wrote:
>> Hi Fabio,
>>
>> I have already add cpufreq driver support in imx6q-cpufreq.c before adding the cpufreq device.
>> Commit: a35fc5a33b62a6c658b8ffe7544c966c1776d128.
>
> Ok, I see. Can you try to run kernel 4.6 on a mx6ul board and run a
> 'reboot' command? You will see a crash related to cpufreq.
>
> cpufreq is broken for mx6ul. Could you please take a look?

Ok, here is the fix:

--- a/drivers/cpufreq/imx6q-cpufreq.c
+++ b/drivers/cpufreq/imx6q-cpufreq.c
@@ -212,7 +212,7 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev)

        if (of_machine_is_compatible("fsl,imx6ul")) {
                pll2_bus_clk = clk_get(cpu_dev, "pll2_bus");
-               secondary_sel_clk = clk_get(cpu_dev, "secondary_sel");
+               secondary_sel_clk = clk_get(cpu_dev, "secondary_sel_clk");
                if (IS_ERR(pll2_bus_clk) || IS_ERR(secondary_sel_clk)) {
                        dev_err(cpu_dev, "failed to get clocks specific to imx6u
                        ret = -ENOENT;


Will send a proper patch.

Thanks



More information about the linux-arm-kernel mailing list