[RFC PATCH 01/21] mfd: uniphier: add UniPhier MFD driver

Masahiro Yamada yamada.masahiro at socionext.com
Tue May 10 18:51:51 PDT 2016


Hi Lee,

2016-05-10 20:26 GMT+09:00 Lee Jones <lee.jones at linaro.org>:
>> +};
>> +MODULE_DEVICE_TABLE(of, uniphier_mfd_match);
>
> NACK.  Please do not mix MFD and DT registration.

OK, thanks for review.


My basic thought was:

  - Add an MFD node to my DTS only once.
    If I need to expand it in the future, I will just
    need to modify drivers/mtd/uniphier-mfd.c.
    It is just kernel-internal modification, so it does not
    bother DT binding at all.

  - Simplify the node topology of DTS.

-- 
Best Regards
Masahiro Yamada



More information about the linux-arm-kernel mailing list