[PATCH V2 3/3] nvmem: imx-ocotp: handling clock
srinivas.kandagatla at linaro.org
Mon May 9 05:28:14 PDT 2016
Thanks for the Ping, I totally missed this thread.
On 20/04/16 18:26, Peng Fan wrote:
> Before access ocotp nvmem area, the clock should be enabled.
> Or, `hexdump nvmem` will hang the system. So, use such flow:
> 1. clock_enable_prepare
> 2. read nvmem ocotp area
> 3. clock_disable_unprepare
> Signed-off-by: Peng Fan <van.freenix at gmail.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
> Cc: Maxime Ripard <maxime.ripard at free-electrons.com>
> Cc: Shawn Guo <shawnguo at kernel.org>
> Follow Fabio's comments, check return value of clk_prepare_enable
> drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
Changes to the driver looks good to me,
Only one comment, As the clock property is now made mandatory, you
should update the dt-bindings with this info too.
More information about the linux-arm-kernel