[PATCH v2 04/11] clocksource/moxart: Generalise timer for use on other socs

Joel Stanley joel at jms.id.au
Mon May 2 22:56:33 PDT 2016

Hey Daniel,

Thanks for the review.

On Sat, Apr 23, 2016 at 3:00 AM, Daniel Lezcano
<daniel.lezcano at linaro.org> wrote:
> On 04/21/2016 10:04 AM, Joel Stanley wrote:
>> The moxart timer IP is shared with another soc made by Aspeed.
>> Generalise the registers that differ so the same driver can be used for
>> both.
>> As we now depend on CLKSRC_MMIO, create a Kconfig symbol for the driver
>> so we can express this dependency.
>> Signed-off-by: Joel Stanley <joel at jms.id.au>
>> ---
> In the future, please Cc the maintainers.


> You probably can remove all the unused macro definition here for both MOXART
> and ASPEED to have something just a couple of definition.

I agree with Ben; we're helping out by documenting the hardware in
lieu of a public datasheet. I'd prefer to keep this here.

>>   static void __iomem *base;
>>   static unsigned int clock_count_per_tick;
>> +static unsigned int t1_disable_val, t1_enable_val;
> It will be cleaner to:
> 1. Factor out:
>         writel(TIMER1_DISABLE, base + TIMER_CR);
>         writel(TIMER1_ENABLE, base + TIMER_CR);

I considered this myself but went with the minimal change. I'm not
fussed, so I will rework it as you suggest.

>From the register layout I suspect this IP block is a Faraday Tech
FTTMR010[1], but I don't have any other evidence. Would you take a
patch to change the name or would you prefer leaving it as moxart?



[1] https://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg04333.html

More information about the linux-arm-kernel mailing list