[PATCH 2/2] arm*: efi: drop writable mapping of the UEFI System table

Matt Fleming matt at codeblueprint.co.uk
Wed Mar 23 09:16:24 PDT 2016


On Tue, 22 Mar, at 04:08:24PM, Ard Biesheuvel wrote:
> 
> This patch causes a warning I hadn't spotted before sending it out.
> Could you fold this in please?
> 
> diff --git a/drivers/firmware/efi/arm-runtime.c
> b/drivers/firmware/efi/arm-runtime.c
> index 6c97d4884fc7..fe749da9997e 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -72,8 +72,8 @@ static bool __init efi_virtmap_init(void)
>                  */
>                 if (efi_system_table >= phys &&
>                     efi_system_table < phys + (md->num_pages * EFI_PAGE_SIZE)) {
> -                       efi.systab = (void *)(efi_system_table - phys +
> -                                             md->virt_addr);
> +                       efi.systab = (void *)(unsigned long)(efi_system_table -
> +                                                         phys + md->virt_addr);
>                         systab_found = true;
>                 }
>         }

Done, please check,

  https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=next&id=4fd5c619dcf4f3d2c86d4a686ce66fc01e877a08



More information about the linux-arm-kernel mailing list