[PATCH 1/2] ARM: socfpga: Add support for HPS LEDs on SoCKit

[Steffen Trumtrar]

Hi!

Marek Vasut writes:

> Add support for the blue LEDs on the SoCFPGA SoCkit board.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> ---
>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts | 32 +++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> index b61f22f..1461690 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
> @@ -39,6 +39,34 @@
>  		ethernet0 = &gmac1;
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		hps_led0 {
> +			label = "hps:blue:led0";
> +			gpios = <&portb 24 0>;	/* HPS_GPIO53 */
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		hps_led1 {
> +			label = "hps:blue:led1";
> +			gpios = <&portb 25 0>;	/* HPS_GPIO54 */
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		hps_led2 {
> +			label = "hps:blue:led2";
> +			gpios = <&portb 26 0>;	/* HPS_GPIO55 */
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		hps_led3 {
> +			label = "hps:blue:led3";
> +			gpios = <&portb 27 0>;	/* HPS_GPIO56 */
> +			linux,default-trigger = "heartbeat";
> +		};
> +	};
> +

I'd personally remove the default-triggers.
Otherwise looks good to me.

Regards,
Steffen

-- 
Pengutronix e.K.                           | Steffen Trumtrar            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |