[PATCH 5/5] [media] media-device: make media_device_cleanup() static
Javier Martinez Canillas
javier at dowhile0.org
Wed Mar 16 07:03:38 PDT 2016
Hello Mauro,
The patch looks mostly good to me, I just have a question below:
On Wed, Mar 16, 2016 at 9:04 AM, Mauro Carvalho Chehab
<mchehab at osg.samsung.com> wrote:
[snip]
>
> -void media_device_cleanup(struct media_device *mdev)
> +static void media_device_cleanup(struct media_device *mdev)
> {
> ida_destroy(&mdev->entity_internal_idx);
> mdev->entity_internal_idx_max = 0;
> media_entity_graph_walk_cleanup(&mdev->pm_count_walk);
> - mutex_destroy(&mdev->graph_mutex);
Any reason why this is removed? mutex_init() is still called in
media_device_init() so I believe the destroy should be kept here.
Reviewed-by: Javier Martinez Canillas <javier at osg.samsung.com>
Best regards,
Javier
More information about the linux-arm-kernel
mailing list