[PATCH 2/4] mmc: davinci: fix unwinding in probe

Sekhar Nori nsekhar at ti.com
Mon Mar 14 04:52:46 PDT 2016


Hi David,

On Thursday 10 March 2016 05:20 AM, David Lechner wrote:
> Unwiding from an error in davinci_mmcsd_probe was a mess. Some errors were
> not handled and not all paths unwound correctly.
> 
> Signed-off-by: David Lechner <david at lechnology.com>

Since you are touching this, can you also shift to using devm_*()
variants where possible (like devm_ioremap()). That will simplify the
error handling quite a bit.

Regards,
Sekhar




More information about the linux-arm-kernel mailing list