[PATCH 3/4] arm64: pmu: Add support for probing with ACPI
Jeremy Linton
jeremy.linton at arm.com
Sun Mar 13 18:44:30 PDT 2016
On 03/13/2016 06:28 PM, Timur Tabi wrote:
> Jeremy Linton wrote:
>> + int i, count, irq;
>> +
>> + if (acpi_disabled)
>> + return 0;
>> +
>> + acpi_parse_boot_cpu();
>> +
>> + /* Must have irq for boot boot cpu, at least */
>> + if (pirq->gsi == 0)
>> + return -EINVAL;
>> +
>> + irq = acpi_register_gsi(NULL, pirq->gsi, pirq->trigger,
>> + ACPI_ACTIVE_HIGH);
>> +
>> + if (irq_is_percpu(irq))
>> + count = 1;
>> + else
>> + for (i = 1, count = 1; i < NR_CPUS; i++)
>> + if (pmu_irqs[i].gsi)
>> + ++count;
>
> You could more simply with:
>
> int count = 1
> ...
> if (!irq_is_percpu(irq))
> for (i = 1; i < NR_CPUS; i++)
> if (pmu_irqs[i].gsi)
> ++count;
I think you will notice that the following patch rewrites a lot of this
function.
I kept the original patches from Mark to identify/segment his
contribution because they run/bisect by themselves. They should probably
be squashed together for review purposes.
More information about the linux-arm-kernel
mailing list