[PATCH v3 1/2] ARM: tango: add HOTPLUG_CPU support
marc_gonzalez at sigmadesigns.com
Wed Jun 29 05:28:23 PDT 2016
On 28/06/2016 17:16, Robin Murphy wrote:
> On 28/06/16 16:04, Marc Gonzalez wrote:
>> On 28/06/2016 14:30, Robin Murphy wrote:
>>> Does the firmware guarantee that this will succeed (or at least report
>>> success) in finite time, regardless of how messed up the system might
>>> be? I'd imagine this should probably have either a timeout or a comment
>>> clarifying why it doesn't need a timeout.
>> Good point.
>> The FW allows only one thread at a time. If a thread is wedged inside
>> the FW, no other thread can use the FW. In that situation, cpu0 would
>> remain stuck inside tango_cpu_kill().
>> Note, that if tango_cpu_kill() starts failing, then secondary cores
>> will remain "zombies". So the system is mostly hosed anyway...
>> Only cpu0 will be available.
> Indeed; my thought was that if CPU1 somehow ends up wedged such that
> tango_aux_core_die() never completes, then CPU0 eventually timing out
> and being able to limp through a clean(ish) reboot is probably
> preferable to spinning in cpu_kill() forever.
I have sent an updated patch addressing your comment.
Thanks for flagging the issue.
More information about the linux-arm-kernel