[PATCH] arm64: mm: simplify memblock numa node extraction
Will Deacon
will.deacon at arm.com
Mon Jun 27 09:24:23 PDT 2016
On Wed, Jun 22, 2016 at 12:13:45PM +0100, Mark Rutland wrote:
> We currently open-code extracting the NUMA node of a memblock region,
> which requires an ifdef to cater for !CONFIG_NUMA builds where the
> memblock_region::nid field does not exist.
>
> The generic memblock_get_region_node helper is intended to cater for
> this. For CONFIG_HAVE_MEMBLOCK_NODE_MAP, builds this returns reg->nid,
> and for for !CONFIG_HAVE_MEMBLOCK_NODE_MAP builds this is a static
> inline that returns 0. Note that for arm64,
> CONFIG_HAVE_MEMBLOCK_NODE_MAP is selected iff CONFIG_NUMA is.
>
> This patch makes use of memblock_get_region_node to simplify the arm64
> code. At the same time, we can move the nid variable definition into the
> loop, as this is the only place it is used.
>
> Signed-off-by: Mark Rutland <mark.rutland at arm.com>
> Reviewed-by: Steve Capper <steve.capper at arm.com>
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Will Deacon <will.deacon at arm.com>
> ---
> arch/arm64/mm/init.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Looks like a straightforward cleanup to me:
Acked-by: Will Deacon <will.deacon at arm.com>
Will
More information about the linux-arm-kernel
mailing list