[PATCH 2/2] serial: sirf: make uart register info static
gregkh at linuxfoundation.org
Sat Jun 25 14:01:50 PDT 2016
On Tue, Jun 07, 2016 at 07:06:12PM +0100, Ben Dooks wrote:
> The driver does not export the two structures that
> define the uart register mappings outside of the
> driver, so make them static to avoid the following
> drivers/tty/serial/sirfsoc_uart.h:124:30: warning: symbol 'sirfsoc_usp' was not declared. Should it be static?
> drivers/tty/serial/sirfsoc_uart.h:190:30: warning: symbol 'sirfsoc_uart' was not declared. Should it be static?
> Note, we don't move these into the driver .c file as this would
> be a larger change. However they really should not belong in the
> header file like this.
Please do the correct thing here and move them into the .c file.
More information about the linux-arm-kernel