[PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

Arnd Bergmann arnd at arndb.de
Tue Jun 21 08:31:13 PDT 2016

On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
> -struct syscore_ops mvebu_mbus_syscore_ops = {
> +static struct syscore_ops mvebu_mbus_syscore_ops = {
>         .suspend        = mvebu_mbus_suspend,
>         .resume         = mvebu_mbus_resume,
>  };

Looks good, but I immediately thought it should be "const" as well.
Unfortunately there is a list_head in them, so that isn't easy,
but if anyone has an idea for how to make these all const, that
would be nice.

Anyway, that shouldn't stop your patch from getting merged, so

Acked-by: Arnd Bergmann <arnd at arndb.de>

(also for patch 1/2).


More information about the linux-arm-kernel mailing list