[PATCH 3/4] ARM: dts: imx7d-sdb: Add support for touchscreen

[Shawn Guo]

On Fri, Jun 17, 2016 at 05:09:42PM -0300, Diego Dorta wrote:
> Add support for tsc2046 touchscreen.
> 
> Signed-off-by: Diego Dorta <diego.dorta at nxp.com>
> ---
>  arch/arm/boot/dts/imx7d-sdb.dts | 46 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index c9cf9b0..5f8ef3b 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -111,6 +111,32 @@
>  	arm-supply = <&sw1a_reg>;
>  };
>  
> +&ecspi3 {
> +	fsl,spi-num-chipselects = <1>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_ecspi3 &pinctrl_ecspi3_cs>;

Can just be one pinctrl entry?

> +	cs-gpios = <&gpio5 9 0>;

Use macro in include/dt-bindings/gpio/gpio.h for polarity.

> +	status = "okay";
> +
> +	tsc2046 {

There is a 'reg' property, so the node name should have an unit-address.

> +		compatible = "ti,tsc2046";
> +		reg = <0>;
> +		spi-max-frequency = <1000000>;
> +		pinctrl-names ="default";
> +		pinctrl-0 = <&pinctrl_tsc2046_pendown>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <29 0>;
> +		pendown-gpio = <&gpio2 29 0>;

Use macro in include/dt-bindings/gpio/gpio.h for polarity.

> +		ti,x-min = /bits/ 16 <0>;
> +		ti,x-max = /bits/ 16 <0>;
> +		ti,y-min = /bits/ 16 <0>;
> +		ti,y-max = /bits/ 16 <0>;
> +		ti,pressure-max = /bits/ 16 <0>;
> +		ti,x-plat-ohms = /bits/ 16 <400>;
> +		linux,wakeup;

It's a legacy.  See bindings/power/wakeup-source.txt for the
replacement.

Shawn

> +	};
> +};
> +
>  &fec1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet1>;
> @@ -364,6 +390,20 @@
>  	pinctrl-0 = <&pinctrl_hog>;
>  
>  	imx7d-sdb {
> +		pinctrl_ecspi3_cs: ecspi3_cs_grp {
> +			fsl,pins = <
> +				MX7D_PAD_SD2_CD_B__GPIO5_IO9		0x59
> +			>;
> +		};
> +
> +		pinctrl_ecspi3: ecspi3grp {
> +			fsl,pins = <
> +				MX7D_PAD_SAI2_TX_SYNC__ECSPI3_MISO	0x2
> +				MX7D_PAD_SAI2_TX_BCLK__ECSPI3_MOSI	0x2
> +				MX7D_PAD_SAI2_RX_DATA__ECSPI3_SCLK	0x2
> +			>;
> +		};
> +
>  		pinctrl_enet1: enet1grp {
>  			fsl,pins = <
>  				MX7D_PAD_GPIO1_IO10__ENET1_MDIO			0x3
> @@ -480,6 +520,12 @@
>  			>;
>  		};
>  
> +		pinctrl_tsc2046_pendown: tsc2046_pendown {
> +			fsl,pins = <
> +				MX7D_PAD_EPDC_BDR1__GPIO2_IO29		0x59
> +			>;
> +		};
> +
>  		pinctrl_uart1: uart1grp {
>  			fsl,pins = <
>  				MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX	0x79
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel