[PATCH 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround
Shawn Guo
shawnguo at kernel.org
Mon Jun 20 19:40:18 PDT 2016
On Thu, Jun 16, 2016 at 05:47:26PM +0200, Arnd Bergmann wrote:
> On Wednesday, June 1, 2016 5:29:42 PM CEST Lucas Stach wrote:
> > +/*
> > + * i.MX6 Q/DL has an erratum (ERR006687) that prevents the FEC from waking the
> > + * CPUs when they are in wait(unclocked) state. As the hardware workaround isn't
> > + * applicable to all boards, disable the deeper idle state when the workaround
> > + * isn't present and the FEC is in use.
> > + */
> > +void imx6q_cpuidle_fec_irqs_used(void)
> > +{
> > + imx6q_cpuidle_driver.states[1].disabled = true;
> > +}
> > +
> > +void imx6q_cpuidle_fec_irqs_unused(void)
> > +{
> > + imx6q_cpuidle_driver.states[1].disabled = false;
> > +}
> > +
>
> These functions need to be exported, I just saw a build error in
> an allmodconfig test:
>
> ERROR: "imx6q_cpuidle_fec_irqs_unused" [drivers/net/ethernet/freescale/fec.ko] undefined!
> ERROR: "imx6q_cpuidle_fec_irqs_used" [drivers/net/ethernet/freescale/fec.ko] undefined!
Thanks for the report, Arnd. Just sent a fix for it.
Shawn
More information about the linux-arm-kernel
mailing list