[PATCH 0/8] arm64: pmu: Detect multiple PMU types in an ACPI system

Punit Agrawal punit.agrawal at arm.com
Mon Jun 20 09:47:48 PDT 2016


Jeremy Linton <jeremy.linton at arm.com> writes:

> v5:
> Remove list of CPU types for ACPI systems. We now match a generic
> event list, and use the PMCIED[01] to select events which exist on
> the given PMU. This avoids the need to update the kernel every-time
> a new CPU is released.
> Update the maintainers list to include the new file.
>
> v4:
> Correct build issues with ARM (!ARM64) kernels.
> Add ThunderX to list of PMU types.
>
> v3:
> Enable ARM performance monitoring units on ACPI/arm64 machines.
>
> This patch expands and reworks the patches published by Mark Salter
> in order to clean up a few of the previous review comments, as well as
> add support for newer CPUs and big/little configurations.
>

Hi Jeremy,

I have a few comments on the individual patches but overall I found the
patches a bit confusing due to introduction of functionality and then
changing them in later patches.

IMHO, some patch re-organisation to make the series better as a whole will
help in review (even though it may lead to more invasive changes
to Mark's patches).

Thanks,
Punit


> Jeremy Linton (6):
>   arm64: pmu: Probe default hw/cache counters
>   arm: arm64: Add routine to determine cpuid of other cpus
>   arm: arm64: pmu: Assign platform PMU CPU affinity
>   arm64: pmu: Add routines for detecting differing PMU types in the
>   arm64: pmu: Enable multiple PMUs in an ACPI system
>   MAINTAINERS: Tweak ARM PMU maintainers
>
> Mark Salter (2):
>   arm64: pmu: add fallback probe table
>   arm64: pmu: Add support for probing with ACPI
>
>  MAINTAINERS                      |   3 +-
>  arch/arm/include/asm/cputype.h   |   6 +-
>  arch/arm64/include/asm/cputype.h |   4 +
>  arch/arm64/kernel/perf_event.c   |  51 ++++++++-
>  arch/arm64/kernel/smp.c          |   5 +
>  drivers/perf/Kconfig             |   4 +
>  drivers/perf/Makefile            |   1 +
>  drivers/perf/arm_pmu.c           |  57 +++++++++--
>  drivers/perf/arm_pmu_acpi.c      | 216 +++++++++++++++++++++++++++++++++++++++
>  include/linux/perf/arm_pmu.h     |  10 ++
>  10 files changed, 341 insertions(+), 16 deletions(-)
>  create mode 100644 drivers/perf/arm_pmu_acpi.c



More information about the linux-arm-kernel mailing list