[PATCH 3/7] crypto: marvell: Copy IV vectors by DMA transfers for acipher requests

Gregory CLEMENT gregory.clement at free-electrons.com
Thu Jun 16 01:32:05 PDT 2016


Hi Romain,
 
 On jeu., juin 16 2016, Romain Perier <romain.perier at free-electrons.com> wrote:

>
>>> diff --git a/drivers/crypto/marvell/cesa.h b/drivers/crypto/marvell/cesa.h
>>> index 74071e4..74b84bd 100644
>>> --- a/drivers/crypto/marvell/cesa.h
>>> +++ b/drivers/crypto/marvell/cesa.h
>>> @@ -275,6 +275,7 @@ struct mv_cesa_op_ctx {
>>>   #define CESA_TDMA_DUMMY				0
>>>   #define CESA_TDMA_DATA				1
>>>   #define CESA_TDMA_OP				2
>>> +#define CESA_TDMA_IV				4
>>
>> Should be 3 and not 4: TDMA_TYPE is an enum, not a bit field.
>
> Ok
>
>>
>> Sometime it's better to offend the < 80 characters rule than doing
>> funky stuff ;).
>
> I just wanted to make checkpatch happy :D

In this case you can use a temporary variable.


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list