[PATCH v3 2/2] ARM: dts: utilite-pro: add mmc card slot support
Igor Grinberg
grinberg at compulab.co.il
Tue Jun 14 23:40:01 PDT 2016
Hi Christopher,
On 06/13/2016 02:24 AM, christopher.spinrath at rwth-aachen.de wrote:
> From: Christopher Spinrath <christopher.spinrath at rwth-aachen.de>
>
> The Utilite Pro has a mmc card slot connected to the usdhc3
> controller. There is no card detection until hardware revision 1.3.
>
> Add support for it and signal the controller with the broken-cd
> property that polling has to be used to detect a card.
>
> Signed-off-by: Christopher Spinrath <christopher.spinrath at rwth-aachen.de>
> Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>
> Notes:
> Changes since v2:
> - add Fabio's Reviewed-By
>
> Changes since v1:
> - enhance commit message to explain to the broken-cd property
>
> arch/arm/boot/dts/imx6q-utilite-pro.dts | 44 +++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6q-utilite-pro.dts b/arch/arm/boot/dts/imx6q-utilite-pro.dts
> index 7219745..6199063 100644
> --- a/arch/arm/boot/dts/imx6q-utilite-pro.dts
> +++ b/arch/arm/boot/dts/imx6q-utilite-pro.dts
[...]
> @@ -151,3 +184,14 @@
> uart-has-rtscts;
> status = "okay";
> };
> +
> +&usdhc3 {
> + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> + pinctrl-0 = <&pinctrl_usdhc3>;
> + pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> + pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> + no-1-8-v;
> + broken-cd;
A wast majority of boards produced are of revision >=1.3.
Can we please have the default as revision 1.3 with cd?
And let the patch you have submitted to U-Boot do the job
for older revisions?
> + keep-power-in-suspend;
> + status = "okay";
> +};
>
--
Regards,
Igor.
More information about the linux-arm-kernel
mailing list