[PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume

Stefan Agner stefan at agner.ch
Mon Jun 13 19:42:10 PDT 2016

On June 13, 2016 5:18:19 PM PDT, Bhhuvanchandra DV <bhuvanchandra.dv at toradex.com> wrote:
>Hi Shawn,
>On 06/11/2016 02:03 PM, Shawn Guo wrote:
>> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote:
>>> From: Stefan Agner <stefan at agner.ch>
>>> In order to allow wake support in STOP sleep mode, clocks are
>>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating
>>> in low power mode STOP. This allows to enable wake by UART using:
>>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup
>>> However, if wake is not enabled, the driver should disable the
>>> clocks explicitly to save power.
>>> Signed-off-by: Stefan Agner <stefan at agner.ch>
>>> ---
>>>   drivers/clk/imx/clk-vf610.c     | 12 ++++++------
>> Please send clock driver changes in a separate patch.

The changes are dependet on each other, hence I put it in a single patch. But since it is a new feature it shouldn't really matter...

>How about splitting this patchset to two? few patches are having minor
>fixes and the few patches might need some review and discussions.
>May be some thing like DMA fixes and the other minor fixes.

I don't think that splitting up the patchset is necessary, with the current order it is possible to pick up the fixes independently...


>> Shawn
>>>   drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++--
>>>   2 files changed, 20 insertions(+), 8 deletions(-)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

More information about the linux-arm-kernel mailing list