[PATCH 3/3] i.MX: system.c: Replace magic numbers
Russell King - ARM Linux
linux at armlinux.org.uk
Mon Jun 13 02:41:07 PDT 2016
On Mon, Jun 13, 2016 at 11:24:02AM +0200, Arnd Bergmann wrote:
> On Sunday, June 12, 2016 10:55:29 PM CEST Andrey Smirnov wrote:
> > @@ -61,6 +61,13 @@
> > #define L2X0_LINE_TAG 0xF30
> > #define L2X0_DEBUG_CTRL 0xF40
> > #define L310_PREFETCH_CTRL 0xF60
> > +#define L310_DOUBLE_LINEFILL_EN BIT(30)
> > +#define L310_INSTRUCTION_PREFETCH_EN BIT(29)
> > +#define L310_DATA_PREFETCH_EN BIT(28)
> > +#define L310_DOUBLE_LINEFILL_ON_WRAP_READ_DIS BIT(27)
> > +#define L310_PREFETCH_DROP_EN BIT(24)
> > +#define L310_INCR_DOUBLE_LINEFILL_EN BIT(23)
> > +#define L310_ESCLUSIVE_SEQUENCE_EN BIT(21)
> > #define L310_POWER_CTRL 0xF80
> > #define L310_DYNAMIC_CLK_GATING_EN (1 << 1)
> > #define L310_STNDBY_MODE_EN (1 << 0)
> > diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
> >
>
>
> Most of these macros seem to all exist further down in the file already
> under slightly differnet names, e.g.
>
> #define L310_PREFETCH_CTRL_DBL_LINEFILL_INCR BIT(23)
Indeed they do. Andrey, please use the existing definitions.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
More information about the linux-arm-kernel
mailing list