[PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led

Maxime Ripard maxime.ripard at free-electrons.com
Sat Jun 11 08:45:33 PDT 2016


On Wed, Jun 08, 2016 at 03:23:31PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 07-06-16 23:24, Maxime Ripard wrote:
> >On Sun, Jun 05, 2016 at 02:23:11PM +0200, Hans de Goede wrote:
> >>The blue led on the Mele A1000 is wired to light up as soon as the board
> >>has powered (it will be on while the gpio is still in input / floating
> >>mode), also its location on the top-set box clearly signals "power led".
> >>
> >>Until now we've been treating this as a generic usr function led, which
> >>means that when you plug power into the top-set box, the power-led lights
> >>and then turns off as soon as the kernel loads, which looks wrong.
> >
> >I'm not sure I understand the relationship between usr vs pwr led and
> >the fact that it's disabled.
> 
> There is no relation, other then that pwr leds typically have
> default-state = "on"; set whereas usr leds do not.
> 
> >>This renames the led from a1000:blue:usr to a1000:blue:pwr and marks
> >>it as default on, fixing this.
> >
> >however, the default on might. Is it just a confusing commit log, or
> >am I overlooking something?
> 
> Just a slightly confusing commit log.

Ok, applied all three.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160611/1fed2eb6/attachment.sig>


More information about the linux-arm-kernel mailing list