[PATCH 3/5] arm64: dts: msm8916: Add spc compat tag

Andy Gross andy.gross at linaro.org
Fri Jun 10 14:52:45 PDT 2016


On 10 June 2016 at 16:16, Lina Iyer <lina.iyer at linaro.org> wrote:
> On Fri, Jun 10 2016 at 10:47 -0600, Andy Gross wrote:
>>
>> On Fri, Jun 10, 2016 at 05:25:55PM +0100, Mark Rutland wrote:
>>>
>>> On Fri, Jun 10, 2016 at 11:12:34AM -0500, Andy Gross wrote:
>>> > On Fri, Jun 10, 2016 at 04:48:57PM +0100, Mark Rutland wrote:
>>> > > [+ Lorenzo]
>>> > >
>>> > > On Thu, May 19, 2016 at 12:00:18AM -0500, Andy Gross wrote:
>
> <...>
>>>
>>>
>>> > I chose to do this outside of the arm cpuidle driver because I didn't
>>> > want to
>>> > add any more DT information aside from the compatible, and I needed a
>>> > separate
>>> > place for the Qualcomm specific suspend code.
>>>
>>> Which suspend code is Qualcomm-specific? There shouldn't be anything on
>>> the PSCI side, so I can only imagine that device management is left.
>>> What am I missing?
>>
>>
>
>> Qualcomm won't be supporting the psci suspend feature and will be doing
>> their
>> own thing.  As such, they need their own suspend ops.  In addition, we
>> have
>> platforms that don't use psci (32 bit).
>>
> Andy, which PSCI suspend feature are you referring to, here? On 8916, we
> do support CPU_SUSPEND in PSCI.
>
> You don't want to call SYSTEM_SUSPEND, as it requires the other CPUs to
> be CPU_OFF (hotplugged off) before the last core calls this PSCI
> function.

I was referring to the SYSTEM_SUSPEND psci feature.  It was my
understanding that wouldn't be supported on the Qualcomm platforms.

Regards,

Andy



More information about the linux-arm-kernel mailing list