[PATCH] ARM: orion: remove unreferenced board-d2net.c
simon.guinot at sequanux.org
Fri Jun 10 05:49:36 PDT 2016
On Thu, Jun 09, 2016 at 06:36:08PM +0200, Andrew Lunn wrote:
> On Thu, Jun 09, 2016 at 04:52:35PM +0100, Ben Dooks wrote:
> > On 09/06/16 15:12, Thomas Petazzoni wrote:
> > > Hello,
> > >
> > > On Thu, 9 Jun 2016 16:10:06 +0200, Andrew Lunn wrote:
> > >
> > >>> That being said, this has been broken more than 2 years ago, and nobody
> > >>> noticed. Doesn't this mean that we could get rid of the support for
> > >>> this board entirely? :)
> > >>
> > >> Well, all it means is the LEDs don't blink. If the disk was not
> > >> spinning, or the ethernet device missing, i would agree with you. But
> > >> somebody could be using this device and don't notice the difference
> > >> with the LEDs.
> > Surely DT can manage blinking LEDs??
> There is an additional GPIO needed. However, i think a pin hog should
> allow this to be represented in DT. Two years ago, i don't think this
> sort of hogging existed.
I think this LED device is compatible with the leds-ns2 driver. If it is
true, then the LED definition can be moved into the DT file. I'll look
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the linux-arm-kernel