[Linux-kernel] [PATCH] pinctrl: nomadik: fix warnings from unexported functions
ben.dooks at codethink.co.uk
Wed Jun 8 02:15:30 PDT 2016
On 07/06/16 18:30, Ben Dooks wrote:
> On 07/06/16 18:25, Ben Dooks wrote:
>> There are five functions in the driver that are defined but
>> only used locally. Make these static to avoid the following
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1036:6: warning: symbol 'nmk_gpio_clocks_enable' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1050:6: warning: symbol 'nmk_gpio_clocks_disable' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1073:6: warning: symbol 'nmk_gpio_wakeups_suspend' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1094:6: warning: symbol 'nmk_gpio_wakeups_resume' was not declared. Should it be static?
>> drivers/pinctrl/nomadik/pinctrl-nomadik.c:1120:6: warning: symbol 'nmk_gpio_read_pull' was not declared. Should it be static?
> Apologies, wrong version of the patch without a typo fix in it.
Given these functions are not being used, should I just consider a
patch to remove these. If they are not being considered for future
development it might be a good idea?
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genies
More information about the linux-arm-kernel