[PATCH 07/34] clk: berlin: Migrate to clk_hw based registration and OF APIs

Stephen Boyd stephen.boyd at linaro.org
Tue Jun 7 01:40:47 PDT 2016


Quoting Alexandre Belloni (2016-06-05 10:41:57)
> Hi,
> 
> The main drawback of those patches is that they break the alignment
> (checkpatch.pl --strict complains).

Didn't checkpatch --strict already warn on these files though? I'm not
sure I've done anything to break the alignment style here.

> 
> On 01/06/2016 at 16:15:06 -0700, Stephen Boyd wrote :
> > diff --git a/drivers/clk/berlin/berlin2-avpll.h b/drivers/clk/berlin/berlin2-avpll.h
> > index a37f5068d299..17e311153b42 100644
> > --- a/drivers/clk/berlin/berlin2-avpll.h
> > +++ b/drivers/clk/berlin/berlin2-avpll.h
> > @@ -19,17 +19,13 @@
> >  #ifndef __BERLIN2_AVPLL_H
> >  #define __BERLIN2_AVPLL_H
> >  
> > -struct clk;
> > -
> >  #define BERLIN2_AVPLL_BIT_QUIRK              BIT(0)
> >  #define BERLIN2_AVPLL_SCRAMBLE_QUIRK BIT(1)
> >  
> > -struct clk * __init
> > -berlin2_avpll_vco_register(void __iomem *base, const char *name,
> > +int berlin2_avpll_vco_register(void __iomem *base, const char *name,
> 
> This is missing __init.

Ah I also removed __init in the header file here because it doesn't do
anything. I guess I should mention that in the commit text.



More information about the linux-arm-kernel mailing list