[PATCH] ARM: orion: remove unreferenced board-d2net.c

Gregory CLEMENT gregory.clement at free-electrons.com
Wed Jul 27 07:42:41 PDT 2016


Hi Thomas,
 
 On jeu., juin 09 2016, Thomas Petazzoni <thomas.petazzoni at free-electrons.com> wrote:

> Hello,
>
> On Thu, 9 Jun 2016 15:31:16 +0200, Andrew Lunn wrote:
>> On Thu, Jun 09, 2016 at 11:04:16AM +0100, Ben Dooks wrote:
>> > Either this has been mis-converted (and needs to be fixed) or
>> > is no longer referenced and can be safely removed.  
>> 
>> Hi Thomas
>> 
>> You added this code, which Ben is removing. It does look like you
>> forgot to call d2net_init() from orion5x_dt_init().
>> 
>> Please could you look at this.
>
> You are correct: d2net_init() should be called from orion5x_dt_init(),
> or called through some initcall mechanism.

So should we apply the patch as is or wait for the needed fix for this
board?

Gregory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list