[PATCH] ARM: dts: armada388-clearfog: number LAN ports properly

Gregory CLEMENT gregory.clement at free-electrons.com
Wed Jul 27 03:19:01 PDT 2016


Hi,
 
 On ven., juil. 08 2016, Andrew Lunn <andrew at lunn.ch> wrote:

> On Fri, Jul 08, 2016 at 02:58:39PM +0100, Russell King wrote:
>> Currently, the ports as seen from the rear number as:
>> 
>> 	eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6
>> 
>> which is illogical - this came about because the rev 2.0 boards have the
>> LEDs on the front for the DSA switch (lan5-1) reversed.  Rev 2.1 boards
>> fixed the LED issue, and the Clearfog case numbers the lan ports
>> increasing from left to right.
>> 
>> Maintaining this illogical numbering causes confusion, with reports that
>> "my link isn't coming up" and "my connection negotiates 10base-Half"
>> both of which are due to people thinking that the port next to the SFP
>> is lan1.
>> 
>> Fix this by renumbering the ports to match people's expectations.
>> 
>> Signed-off-by: Russell King <rmk+kernel at armlinux.org.uk>
>
> Reviewed-by: Andrew Lunn <andrew at lunn.ch>

I missed this patch, but I now applied it on mvebu/dt-4.9

Thanks,

Gregory

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list