[PATCH] arm64: Fix Kconfig dependencies for RANDOMIZE_BASE

Catalin Marinas catalin.marinas at arm.com
Tue Jul 26 10:45:56 PDT 2016


On Tue, Jul 26, 2016 at 10:16:55AM -0700, Jeff Vander Stoep wrote:
> Selecting CONFIG_RANDOMIZE_BASE=y and CONFIG_MODULES=n causes a
> build error due to dependencies on modules. This patch makes KASLR
> module config options dependent on CONFIG_MODULES=y.
> 
> Signed-off-by: Jeff Vander Stoep <jeffv at google.com>
> ---
>  arch/arm64/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7e23f95..c9eff79 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -891,7 +891,6 @@ config RELOCATABLE
>  
>  config RANDOMIZE_BASE
>  	bool "Randomize the address of the kernel image"
> -	select ARM64_MODULE_PLTS
>  	select RELOCATABLE
>  	help
>  	  Randomizes the virtual address at which the kernel image is

I thought we need the module PLTs once we randomize the kernel base,
independent of whether we randomize the modules base or not. Could we do
something like:

	select ARM64_MODULE_PLTS if MODULES

Whichever way we fix this, we probably need:

Fixes: f80fb3a3d508 ("arm64: add support for kernel ASLR")
Cc: <stable at vger.kernel.org> # 4.6+

-- 
Catalin



More information about the linux-arm-kernel mailing list