[PATCH 1/2] arm64: mm: make create_mapping_late() non-allocating

Mark Rutland mark.rutland at arm.com
Mon Jul 25 07:22:42 PDT 2016


On Mon, Jul 25, 2016 at 04:10:50PM +0200, Ard Biesheuvel wrote:
> > On 25 jul. 2016, at 15:46, Mark Rutland <mark.rutland at arm.com> wrote:
> > How about we drop the __init marker from create_mapping_noalloc(), and
> > update the callers in mark_rodata_ro() to use that, so that we can drop
> > create_mapping_late() entirely.
> > 
> > Other than the __init marker and name, create_mapping_late() and
> > create_mapping_noalloc() would be identical after this change, and the
> > naming of create_mapping_noalloc() does better describe what we're
> > trying to achieve in mark_rodata_ro().
> 
> Not entirely. The _late() variant should map down to pages if the
> first mapping was mapped down to pages as well. The _noalloc() variant
> may end attempting to merge regions

Ah, I was comparing against mainline rather than the arm64 for-next/core
branch with the recent rework. Sorry for the noise.

Given that, FWIW:

Acked-by: Mark Rutland <mark.rutland at arm.com>

Mark.



More information about the linux-arm-kernel mailing list