[PATCH 2/2] ARM: dts: r8a7792: add SDHI support
Sergei Shtylyov
sergei.shtylyov at cogentembedded.com
Mon Jul 18 12:12:40 PDT 2016
Hello.
On 07/18/2016 01:58 AM, Simon Horman wrote:
>> Define the generic R8A7792 part of the SDHI0 device node.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>>
>> ---
>> arch/arm/boot/dts/r8a7792.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7792.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7792.dtsi
>> @@ -435,6 +435,18 @@
>> status = "disabled";
>> };
>>
>> + sdhi0: sd at ee100000 {
>> + compatible = "renesas,sdhi-r8a7792";
>> + reg = <0 0xee100000 0 0x200>;
>
> I do not have the documentation available to check,
Me nether. The SDHI .zip only includes the manual for E2, H2, and M2.
> however, I wonder if
> as per 66f47ed0e86d ("ARM: shmobile: r8a7790: tidyup SDHI register size on
> DTSI") the register size should be 0x328.
I just don't know...
> It also looks like register the DTS for the r8a7794 needs updating along
> the same lines.
Indeed.
>> + interrupts = <0 165 IRQ_TYPE_LEVEL_HIGH>;
>> + dmas = <&dmac0 0xcd>, <&dmac0 0xce>,
>> + <&dmac1 0xcd>, <&dmac1 0xce>;
>> + dma-names = "tx", "rx", "tx", "rx";
>> + clocks = <&mstp3_clks R8A7792_CLK_SDHI0>;
>> + power-domains = <&sysc R8A7792_PD_ALWAYS_ON>;
>> + status = "disabled";
>> + };
>> +
>> jpu: jpeg-codec at fe980000 {
>> compatible = "renesas,jpu-r8a7792",
>> "renesas,rcar-gen2-jpu";
I also wonder whether whether a single per-SoC SDHI "compatible" is valid.
The registers and their offsets seem to differ b/w SDHI0 and the other SDHI
cores...
MBR, Sergei
More information about the linux-arm-kernel
mailing list