[PATCH 3/6] ARM: dts: imx25: substitute NO_PAD_CTL by the respective reset value
Fabio Estevam
festevam at gmail.com
Tue Jul 12 13:40:13 PDT 2016
On Tue, Jul 12, 2016 at 5:30 PM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Uwe,
>
> On Tue, Jul 12, 2016 at 4:15 PM, Uwe Kleine-König
> <u.kleine-koenig at pengutronix.de> wrote:
>
>>> @@ -244,7 +244,7 @@
>>> fsl,pins = <
>>> MX25_PAD_UART1_RTS__UART1_RTS 0xe0
>>> MX25_PAD_UART1_CTS__UART1_CTS 0xe0
>>> - MX25_PAD_UART1_TXD__UART1_TXD 0x80000000
>>> + MX25_PAD_UART1_TXD__UART1_TXD 0x00
>>> MX25_PAD_UART1_RXD__UART1_RXD 0xc0
>>
>> Are you sure here? According to the reference manual bit 0x40 of
>> IOMUXC_SW_PAD_CTL_PAD_UART1_RXD isn't valid. And my i.mx25 based machine
>> agrees:
>>
>> barebox at imx25:/ mw 0x43fac368 0xc0
>> barebox at imx25:/ md 0x43fac368+4
>> 43fac368: 00000080
>
> Let me double check it when I get access to this board again.
Sorry, I misread.
You were referring to MX25_PAD_UART1_RXD__UART1_RXD, not
MX25_PAD_UART1_TXD__UART1_TXD.
I didn't touch MX25_PAD_UART1_RXD__UART1_RXD, so your series does the
right thing for this pad (put it at 0x80).
More information about the linux-arm-kernel
mailing list