[PATCH] media: s5p-mfc Fix misspelled error message and checkpatch errors

Javier Martinez Canillas javier at osg.samsung.com
Tue Jul 12 08:03:32 PDT 2016


Hello Shuah,

On 07/11/2016 06:39 PM, Shuah Khan wrote:
> Fix misspelled error message and existing checkpatch errors in the
> error message conditional.
> 
> WARNING: suspect code indent for conditional statements (8, 24)
>  	if (ctx->state != MFCINST_HEAD_PARSED &&
> [...]
> +               mfc_err("Can not get crop information\n");
> 
> Signed-off-by: Shuah Khan <shuahkh at osg.samsung.com>
> ---

Patch looks good to me. Maybe is better to split the message and checkpatch
changes in two different patches. But I don't have a strong opinion on this:

Reviewed-by: Javier Martinez Canillas <javier at osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America



More information about the linux-arm-kernel mailing list