[PATCH -next] [media] VPU: mediatek: fix return value check in mtk_vpu_probe()
weiyj_lk at 163.com
weiyj_lk at 163.com
Tue Jul 12 04:00:55 PDT 2016
From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
In case of error, the function devm_clk_get() returns ERR_PTR()
and not returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
---
drivers/media/platform/mtk-vpu/mtk_vpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platform/mtk-vpu/mtk_vpu.c
index b60d02c..c8b2c72 100644
--- a/drivers/media/platform/mtk-vpu/mtk_vpu.c
+++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c
@@ -788,9 +788,9 @@ static int mtk_vpu_probe(struct platform_device *pdev)
/* Get VPU clock */
vpu->clk = devm_clk_get(dev, "main");
- if (!vpu->clk) {
+ if (IS_ERR(vpu->clk)) {
dev_err(dev, "get vpu clock failed\n");
- return -EINVAL;
+ return PTR_ERR(vpu->clk);
}
platform_set_drvdata(pdev, vpu);
More information about the linux-arm-kernel
mailing list