[PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry
Andrew Lunn
andrew at lunn.ch
Sun Jul 10 15:27:43 PDT 2016
On Sun, Jul 10, 2016 at 09:45:46PM +0100, Russell King - ARM Linux wrote:
> On Sun, Jul 10, 2016 at 10:37:51PM +0200, Andrew Lunn wrote:
> > The armada-38x.dtsi has
> >
> > ref_clk0_pins: ref-clk-pins-0 {
> > marvell,pins = "mpp45";
> > marvell,function = "ref";
> > };
> >
> > which you could reference rather then defining it yourself.
>
> Weren't these going to be deleted from the main SoC dtsi files,
> eventually? I thought that was the idea, to prevent cluttering
> up the .dtb files with nodes which aren't ever used.
I've not heard they are going to be removed....
Having work on mvebu, and a Freescale Vybrid board, i see two
different styles. mvebu defines all the common pinctrl values in the
.dtsi file, so making the .dts file pretty minimalist. For the vybrid
board there was nothing in the .dtsi file, the dts file is huge, and i
made at least one error, missing at required pin which took me a while
to debug.
I would also say cluttered .dtb because of unused nodes it a compiler
issue. Why does it not optimise them out?
Andrew
More information about the linux-arm-kernel
mailing list