[PATCH v2] serial: amba-pl011: complete support to ZTE uart
Shawn Guo
shawnguo at kernel.org
Thu Jul 7 08:01:07 PDT 2016
On Thu, Jul 07, 2016 at 05:54:53PM +0800, Shawn Guo wrote:
> On Mon, May 16, 2016 at 10:31:37AM +0800, Jun Nie wrote:
> > >> > Russell,
> > >> >
> > >> > Do you have any comments to these change?
> > >> >
> > >> > Jun
> > >>
> > >> Greg,
> > >>
> > >> Do you have any idea on how to drive review on this patch? Seems
> > >> maintainer Russell is too busy and missing for this thread and others
> > >> do not have comments. Your comments are appreciated!
> > >
> > > I would like to get Russell's opinion of this before merging it.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Russell,
> >
> > Could you help have a look at this patch? Thanks!
>
> Hi Russell,
>
> I think this version of the patch is trying to address the comment you
> put on v1, i.e. instead of extending platform driver we should try to
> probe ZTE UART from AMBA bus.
>
> The solution here is to fake a AMBA peripheral ID which does not exist
> on hardware with a magic number. While it's working, it looks too
> hackish, and doesn't really scale in the long run. I hope that's also
> the reason you are unwilling to provide your ACK :)
>
> Unless you have a better solution to suggest, I would think that
> platform driver is a sensible way to support the device, and will go
> back to v1 approach.
Just found that Russell's email address changed. Resend to the new
address.
Shawn
More information about the linux-arm-kernel
mailing list