[PATCH -next] iommu/exynos: Fix return value check in exynos_iommu_of_setup()
Andi Shyti
andi.shyti at samsung.com
Wed Jul 6 19:34:43 PDT 2016
Hi,
just a question,
> > pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
> > - if (IS_ERR(pdev))
> > - return PTR_ERR(pdev);
> > + if (!pdev)
> > + return -ENOMEM;
> >
> > /*
> > * use the first registered sysmmu device for performing
> >
>
is ENOMEM the right return value? of_platform_device_create()
doesn't fail only in case of malloc failure.
Shouldn't it be ENODEV instead, which might also mean with some
imagination that there is no memory available for that device?
Thanks,
Andi
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>
More information about the linux-arm-kernel
mailing list