[PATCH 1/2] coresight-etm3x: Add ARM ETM-A5 peripheral ID

Mathieu Poirier mathieu.poirier at linaro.org
Mon Jul 4 08:33:59 PDT 2016


On 1 July 2016 at 08:37, Olivier Schonken <olivier.schonken at gmail.com> wrote:
> Signed-off-by: Olivier Schonken <olivier.schonken at gmail.com>
> ---
>  drivers/hwtracing/coresight/coresight-etm3x.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
> index d83ab82..2c6d4b4 100644
> --- a/drivers/hwtracing/coresight/coresight-etm3x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm3x.c
> @@ -885,6 +885,11 @@ static struct amba_id etm_ids[] = {
>                 .mask   = 0x0003ffff,
>                 .data   = "ETM 3.3",
>         },
> +       {       /* ETM-A5 */
> +               .id     = 0x0003b955,
> +               .mask   = 0x0003ffff,
> +               .data   = "ETM-A5",
> +       },

Hello,

>From what I see in the documentation A5 and A7 processors have the
same ETM engine.  As such the comment above should be "ETM 3.5 -
Cortex-A5" and the .data field "ETM 3.5".  Get back to me if this
really doesn't mach your architecture.

Thanks,
Mathieu

>         {       /* ETM 3.5 */
>                 .id     = 0x0003b956,
>                 .mask   = 0x0003ffff,
> --
> 1.9.1
>



More information about the linux-arm-kernel mailing list