[PATCH v7 09/17] KVM: arm64: introduce ITS emulation file with MMIO framework

[Andre Przywara]

Hi,

On 04/07/16 14:54, Auger Eric wrote:
> Hi Andre,
> 
> On 04/07/2016 15:38, Andre Przywara wrote:
>> 2) on KVM_DEV_ARM_VGIC_GRP_ADDR check that "initialized" is false
>> 3) on KVM_DEV_ARM_VGIC_CTRL_INIT check that "initialized" is false
>> 4) after KVM_DEV_ARM_VGIC_CTRL_INIT set initialized to true
>>
>> I don't want to rely solely on vgic_its_base being ADDR_UNDEF, since I
>> expect we extend that interface later by supporting more options (for
>> instance to size the virtual ITS, in terms of devices, number of LPIs,
>> collections, etc.)
>>
>> Does that make sense?
>> Or do we need more here?
> 
> So you will accept a call to KVM_DEV_ARM_VGIC_CTRL_INIT with an unset
> address? I don't think this is relevant.

Ah, good point. Will fix this.

However I think we do the same on GICv2/GICv3 at the moment. CTRL_INIT
will succeed, I guess we fail the first KVM_RUN then, right?

Cheers,