[PATCH] clk: ti: omap3+: dpll: use non-locking version of clk_get_rate

Tony Lindgren tony at atomide.com
Thu Jan 28 11:19:49 PST 2016


* Tero Kristo <t-kristo at ti.com> [160128 11:10]:
> On 01/28/2016 09:00 PM, Tony Lindgren wrote:
> >* Tero Kristo <t-kristo at ti.com> [160128 10:48]:
> >>On 01/28/2016 07:22 PM, Tony Lindgren wrote:
> >>>* Tero Kristo <t-kristo at ti.com> [160128 03:44]:
> >>>>On 01/28/2016 01:37 PM, Tero Kristo wrote:
> >>>>>As the code in this file is being executed within irq context in some
> >>>>>cases, we must avoid the clk_get_rate which uses mutex internally.
> >>>>>Switch the code to use clk_hw_get_rate instead which is non-locking.
> >>>>>
> >>>>>Signed-off-by: Tero Kristo <t-kristo at ti.com>
> >>>>
> >>>>Ooops, sorry. Sent wrong version (read: old) of this patch, please ignore
> >>>>this one. Will re-send the correct version in a bit.
> >>>
> >>>I think this is still needed as a fix for -rc cycle with cc: stable
> >>>as otherwise we have omap4 and 5 hang if PM runtime is enabled before
> >>>a suspend/resume cycle?
> >>
> >>Look at the other patch I sent, it should accomplish the same thing, and
> >>more.
> >>
> >>https://www.spinics.net/lists/linux-clk/msg06094.html
> >
> >Right.. But is that suitable for the -rc cycle with cc stable?
> 
> Hmm yea, thats a good question, we may need to resurrect this patch after
> all.

Yes a minimal fix first with cc stable, then the rest of the changes
can be done for v4.6?

> >You should also describe the bug it causes in the change log.
> >Something like:
> >
> >This fixes an issue where PM runtime will hang the system if
> >enabled with a serial console before a suspend-resume cycle.
> 
> Yea I can add this to the desc if we want to keep this version of the patch.

Yes please. It seems the fix should be cc stable for several merge
windows.

Regards,

Tony



More information about the linux-arm-kernel mailing list