[PATCH 1/2] ARM: shmobile: Move shmobile_scu_base from .text to .data

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Thu Jan 28 07:37:19 PST 2016


Hello.

On 01/28/2016 06:04 PM, Geert Uytterhoeven wrote:

> shmobile_scu_base is being written to, so it doesn't belong in the .text
> section. Fix this by moving it from asm .text to C .data, as it's no
> longer used from asm code since commit 4f6da36f7edd5790 ("ARM: shmobile:
> Remove old SCU boot code").
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
[...]

> diff --git a/arch/arm/mach-shmobile/platsmp-scu.c b/arch/arm/mach-shmobile/platsmp-scu.c
> index 64663110ab6ca0e1..f2198c9c74359736 100644
> --- a/arch/arm/mach-shmobile/platsmp-scu.c
> +++ b/arch/arm/mach-shmobile/platsmp-scu.c
> @@ -17,6 +17,9 @@
>   #include <asm/smp_scu.h>
>   #include "common.h"
>
> +

    Why add 2nd empty line?

> +void __iomem *shmobile_scu_base;
> +
>   static int shmobile_smp_scu_notifier_call(struct notifier_block *nfb,
>   					  unsigned long action, void *hcpu)
>   {

MBR, Sergei




More information about the linux-arm-kernel mailing list