[PATCH v2 6/7] ARM: dts: kirkwood: split lswxl dts to linkstation lswsxl and lswxl

[Roger Shimizu]

On Thu, Jan 21, 2016 at 2:21 AM, Sebastian Hesselbarth
<sebastian.hesselbarth at gmail.com> wrote:
> On 01/20/2016 04:33 PM, Roger Shimizu wrote:
>>
>> LS-WXL/WSXL are both kirkwood-6281 based 2-Bay NAS devices, which share
>> many MPP pins. However they are slightly different:
>>    - There're two red LED indicator on LS-WXL to show when HDD fails,
>>      but there's no such on LS-WSXL.
>>    - There's 4-level speed adjustable FAN on LS-WXL, but not LS-WSXL.
>>
>> So after the split, common part goes into .dtsi file:
>>    - kirkwood-linkstation.dtsi
>>    - kirkwood-linkstation-duo-6281.dtsi
>> while all rest part goes into device specific .dts file:
>>    - kirkwood-linkstation-lswsxl.dts
>>    - kirkwood-linkstation-lswxl.dts
>>
>> Signed-off-by: Roger Shimizu <rogershimizu at gmail.com>
>> ---
>
> [...]
>>
>> diff --git a/arch/arm/boot/dts/kirkwood-linkstation-duo-6281.dtsi
>> b/arch/arm/boot/dts/kirkwood-linkstation-duo-6281.dtsi
>> new file mode 100644
>> index 000000000000..47b8f185839d
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/kirkwood-linkstation-duo-6281.dtsi
>> @@ -0,0 +1,185 @@
>
> [...]
>>
>> +/ {
>> +       ocp at f1000000 {
>> +               pinctrl: pin-controller at 10000 {
>
>
> Roger,
>
> nice series! Mind to send another patch moving pinctrl stuff
> and sata below to node references for both boards?
>
> Kirkwood has &pinctrl and &sata labels, it helps to keep the bus
> structure out of the board files. &mdio is an example for that.
>
> I might be easier not to squash that into this series but
> send another one later.

Dear Sebastian,

Understand your point.
I'll create a patch by your suggestion, when this series get committed.
Thanks for your advice!

Cheers,
Roger