[PATCH 1/2] ARM: dts: kirkwood: split lswxl into linkstation lswsxl and lswxl

Andrew Lunn andrew at lunn.ch
Tue Jan 19 17:08:36 PST 2016


> +	gpio_leds {
> +		red-alarm-led {
> +			label = "red:alarm";

Led labels are supposed to have the machine name in them. This used to
be "lswxl:red:alarm". It cannot be so specific now that it is in a
dtsi file. So i would suggest "linkstation:red:alarm".

Otherwise, these changes look O.K.

	   Andrew



More information about the linux-arm-kernel mailing list