[PATCH 3/5] ARM: OMAP2+: Fix save_secure_ram_context for rodata

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Tue Jan 19 10:45:51 PST 2016


Hello.

On 01/19/2016 08:48 PM, Tony Lindgren wrote:

> We don't want to write to .text and we can move save_secure_ram_context
> into .data as it all gets copied into SRAM anyways.
>
> Cc: Kees Cook <keescook at chromium.org>
> Cc: Laura Abbott <labbott at redhat.com>
> Cc: Nicolas Pitre <nicolas.pitre at linaro.org>
> Cc: Nishanth Menon <menon.nishanth at gmail.com>
> Cc: Richard Woodruff <r-woodruff2 at ti.com>
> Cc: Russell King <linux at arm.linux.org.uk>
> Cc: Tero Kristo <t-kristo at ti.com>
> Signed-off-by: Tony Lindgren <tony at atomide.com>
> ---
>   arch/arm/mach-omap2/sleep34xx.S | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S
> index f7c7bf8..042e4fb 100644
> --- a/arch/arm/mach-omap2/sleep34xx.S
> +++ b/arch/arm/mach-omap2/sleep34xx.S
> @@ -93,8 +93,12 @@ ENTRY(enable_omap3630_toggle_l2_on_restore)
>   	ldmfd	sp!, {pc}	@ restore regs and return
>   ENDPROC(enable_omap3630_toggle_l2_on_restore)
>
> -	.text
> -/* Function to call rom code to save secure ram context */
> +/*
> + * Function to call rom code to save secure ram context, This gets

    s/,/./?

> + * relocated to SRAM, so it can be all in .data section. Otherwise
> + * we need to initialize api_params separately.
> + */
> +	.data
>   	.align	3
>   ENTRY(save_secure_ram_context)
>   	stmfd	sp!, {r4 - r11, lr}	@ save registers on stack
[...]

MBR, Sergei




More information about the linux-arm-kernel mailing list