net-thunder: One check less in nicvf_register_interrupts() after error detection
Joe Perches
joe at perches.com
Thu Jan 7 11:59:50 PST 2016
On Thu, 2016-01-07 at 20:56 +0100, SF Markus Elfring wrote:
> > > Is it a bit more efficient to avoid a double check for the
> > > variable "ret" at the end of the current implementation for the
> > > discussed function?
> >
> > Before asking questions you could answer yourself,
> > please look at object code produced by the compiler
> > before and after your proposed changes.
>
> * Do any more source code reviewers wonder about the need
> for such a double check?
Given the feedback you've already received,
it seems so.
> * Which object code representations would you find representative
> for a further constructive discussion around this
> software component?
Evidence of actual object code improvement when
with compiled with optimizations.
More information about the linux-arm-kernel
mailing list