[PATCH] net: hns: avoid uninitialized variable warning:

David Miller davem at davemloft.net
Tue Jan 5 13:43:20 PST 2016

From: Arnd Bergmann <arnd at arndb.de>
Date: Fri, 01 Jan 2016 23:27:57 +0100

> gcc fails to see that the use of the 'last_offset' variable
> in hns_nic_reuse_page() is used correctly and issues a bogus
> warning:
> drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function 'hns_nic_reuse_page':
> drivers/net/ethernet/hisilicon/hns/hns_enet.c:541:6: warning: 'last_offset' may be used uninitialized in this function [-Wmaybe-uninitialized]
> This simplifies the function to make it more obvious what is
> going on to both readers and compilers, which makes the warning
> go away.
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> ---
> Compile-tested only, and complex enough that this requires a proper
> review and testing before it gets apply. Please have a look at this.

If this goes yet another day without being reviewed, I'm just applying

You hisilicon folks can't just let patches rot, you must review them
in a timely manner or else I'm applying them without waiting for you
to look at them.

More information about the linux-arm-kernel mailing list