[PATCH] ASoC: cs35l32: avoid uninitialized variable access
Arnd Bergmann
arnd at arndb.de
Mon Jan 4 07:17:47 PST 2016
On Saturday 02 January 2016 14:17:46 Mark Brown wrote:
> On Sat, Jan 02, 2016 at 12:19:52AM +0100, Arnd Bergmann wrote:
>
> > - if (i2c_client->dev.of_node) {
> > + if (IS_ENABLED(CONFIG_OF) && i2c_client->dev.of_node) {
>
> This would be a lot nicer if there was an __always_null annotation we
> could put on of_node for !OF configurations, that'd Just Work and this
> can't be the only case where we have this idiom.
>
How about an inline helper like
static inline struct device_node *dev_of_node(struct device *dev)
{
if (IS_ENABLED(CONFIG_OF))
return dev->of_node;
}
Arnd
More information about the linux-arm-kernel
mailing list