[PATCH 3/3] ARM: omap1/ams-delta: warn about failed regulator enable

Aaro Koskinen aaro.koskinen at iki.fi
Tue Feb 23 15:40:44 PST 2016

On Tue, Feb 23, 2016 at 02:57:53PM +0100, Arnd Bergmann wrote:
> The modem pm handler in the ams-delta board uses regulator_enable()
> but does not check for a successful return code:
> board-ams-delta.c:521:3: error: ignoring return value of 'regulator_enable', declared with attribute warn_unused_result [-Werror=unused-result]
> It is not easy to propagate that return code to the callers in
> uart_configure_port/uart_suspend_port/uart_resume_port, unless
> we change all UART drivers, and it is unclear what those would
> do with the return code.
> Instead, this patch uses a runtime warning to replace the
> compiletime warning. I have checked that the regulator in question
> is hardcoded to a fixed-voltage GPIO regulator, and that should
> never fail to get enabled if I understand the code right.
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>

Acked-by: Aaro Koskinen <aaro.koskinen at iki.fi>


More information about the linux-arm-kernel mailing list