[PATCH 3/3] arm64: ptdump: include UEFI runtime service mappings

Kees Cook keescook at chromium.org
Mon Feb 22 11:04:56 PST 2016


On Mon, Feb 22, 2016 at 3:51 AM, Ard Biesheuvel
<ard.biesheuvel at linaro.org> wrote:
> On 22 February 2016 at 12:29, Mark Rutland <mark.rutland at arm.com> wrote:
>> Hi,
>>
>> On Mon, Feb 22, 2016 at 11:00:39AM +0100, Ard Biesheuvel wrote:
>>> This adds the UEFI runtime services page table mappings to the output
>>> of the kernel page table dumper. These tables are only live during the
>>> time UEFI runtime services are being invoked, but we can include them
>>> for informational purposes nonetheless.
>>
>> I would prefer that we had a separate file for the EFI runtime services
>> page tables. As you mention, they are distinct from the kernel and not
>> always live (which is also the case for the idmap, for example).
>>
>> I have some local patches atop of v4.3 that librify the dumping code and
>> add a separate file for EFI [1]. I spotted a couple other things in
>> doing that (e.g. that we need to pad addresses more).
>>
>> Is it worth cleaning that up?
>>
>
> I think so. It would be especially nice if we could share the
> registration API between ARM and arm64, since the ptdump code is very
> similar, and the UEFI range is identical between them

In a perfect world, we could unify the ptdump code between x86, arm,
and arm64. Doing this is on my TODO list, but way down the list. :P

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security



More information about the linux-arm-kernel mailing list