[PATCH v6 10/12] arm-cci: CCI-500: Work around PMU counter writes

Mark Rutland mark.rutland at arm.com
Mon Feb 22 07:16:24 PST 2016


A couple more comments for things i just realised:

> +	/*
> +	 * Now that all the counters are disabled, we can safely turn the PMU on,
> +	 * without syncing the status of the counters
> +	 */
> +	__cci_pmu_enable(cci_pmu, CCI_CNTRS_NOSYNC);

As per my other comment, __cci_pmu_enable_nosync(cci_pmu) would be
preferable.

[...]

> +		pmu_write_counter(cci_pmu,
> +				  (u32)local64_read(&event->hw.prev_count), i);

That cast can go.

Mark.



More information about the linux-arm-kernel mailing list